/
/
# What does this implement/fix? When a speaker stops being one of a universal player's outputs and becomes a regular player, it first has to be released from that universal player. Since #5814 the handover that follows cleans up after itself, which makes that release step look like it can go. It cannot: without it the release path takes the emptied universal player out straight away, and that lands before the handover runs, so the user's settings (custom name, hidden, group memberships) are never carried over. Nothing in the test suite noticed, because the tests replace the task scheduler with a mock and the real one starts tasks immediately. **Related issue (if applicable):** - follow-up to #5814 ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) — `bugfix` - [ ] New feature (non-breaking change which adds functionality) — `new-feature` - [ ] Enhancement to an existing feature — `enhancement` - [ ] New music/player/metadata/plugin provider — `new-provider` - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) — `breaking-change` - [ ] Refactor (no behaviour change) — `refactor` - [ ] Documentation only — `documentation` - [x] Maintenance / chore — `maintenance` - [ ] CI / workflow change — `ci` - [ ] Dependencies bump — `dependencies` ## Changes - The existing handover test now runs with the real task scheduler, so dropping the release step fails the suite instead of passing unnoticed. - Updated the comments around it to state why the step is still needed. No behaviour change. ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate.