music-assistant-server
Branch:dev-lidarr-plugin
Commit Details
Fix BBC Sounds recommendations not loading (#6117)
# What does this implement/fix? BBC Sounds recommendations never loaded. The provider called `personal.get_experience_menu()`, which was removed from the sounds library in 2.0, so every fetch raised an `AttributeError`. It now goes through `client.get_menu()`, which is the supported call and also returns an empty menu for listeners outside the UK instead of erroring. The tests stubbed the removed method on a bare `Mock`, so this never showed up. The stub is now `spec_set` against `SoundsClient`. **Related issue (if applicable):** ## Types of changes <!-- Tick exactly one box. CI (.github/workflows/pr-labels.yaml) derives the label from the ticked box and applies it automatically; the release-notes generator uses that same label to slot this change into the next release notes. --> - [x] Bugfix (non-breaking change which fixes an issue) — `bugfix` - [ ] New feature (non-breaking change which adds functionality) — `new-feature` - [ ] Enhancement to an existing feature — `enhancement` - [ ] New music/player/metadata/plugin provider — `new-provider` - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) — `breaking-change` - [ ] Refactor (no behaviour change) — `refactor` - [ ] Documentation only — `documentation` - [ ] Maintenance / chore — `maintenance` - [ ] CI / workflow change — `ci` - [ ] Dependencies bump — `dependencies` ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate. Co-authored-by: Marvin Schenkel <[email protected]>
Author
Marvin Schenkel<[email protected]>
August 31, 2026 at 12:45 PM UTC
Committer
Marvin Schenkel<[email protected]>
September 4, 2026 at 07:55 AM UTC
7additions
8deletions
2files changed
Parent commits
Changes
2 files
+7-8
Changed Files (2)
music_assistant/providers/bbc_sounds/
tests/providers/bbc_sounds/
music_assistant/providers/bbc_sounds/__init__.py
tests/providers/bbc_sounds/test_recommendations.py
+7-8