/
/
/
# What does this implement/fix? Follow-up on #5525. When a player is removed while it is not registered anymore (for example because its provider was unloaded or failed to load), the AirPlay/DLNA/Sendspin endpoints of that same device that _are_ still registered kept pointing at the removed player. Nothing cleared that link or triggered a new evaluation, so those endpoints stayed hidden until the server was restarted. Removing a player now also detaches its protocol players and re-evaluates them, so they get linked to another player or wrapped in a new one right away. **Related issue (if applicable):** - n/a ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) — `bugfix` - [ ] New feature (non-breaking change which adds functionality) — `new-feature` - [ ] Enhancement to an existing feature — `enhancement` - [ ] New music/player/metadata/plugin provider — `new-provider` - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) — `breaking-change` - [ ] Refactor (no behaviour change) — `refactor` - [ ] Documentation only — `documentation` - [x] Maintenance / chore — `maintenance` - [ ] CI / workflow change — `ci` - [ ] Dependencies bump — `dependencies` ## Changes - `delete_player_config` now detaches the still registered protocol players of the player being removed and schedules a fresh protocol evaluation for them. - The parent link is cleared both live and in the stored config, so it also covers a protocol player that was only waiting for a parent that never registered. - Shared the detach logic with the existing permanent-removal cleanup instead of duplicating it. - Added tests for removing a player that is no longer registered while its protocol player still is. ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate.