/
/
/
# What does this implement/fix? Disabling a player and then removing it made the player disappear for good: it never came back, not even after a server restart or re-flashing the device. Disabling a player also disables the protocol player(s) that belong to the same device, but removing the player only wiped its own configuration. The disabled protocol configuration stayed behind, which blocks the device from ever showing up again - and since those entries are never shown in the UI, there was no way to undo it other than hand-editing `settings.json`. - removing a player now also wipes the configuration of the protocol players that belong to it - protocol players that are still in use or already moved to another player keep their settings - leftover entries from before this fix are cleaned up on startup, so affected devices return by themselves **Related issue (if applicable):** - reported on Discord ## Types of changes - [x] Bugfix (non-breaking change which fixes an issue) — `bugfix` ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate.