/
/
# What does this implement/fix? The WiiM provider had a temporary workaround: `volume_set()` copied the body of the SDK's `async_set_volume()` because that method used an unreliable UPnP action. The upstream fix has since shipped and we already pin `wiim==0.1.5`, so the copy can go and we call the SDK again. **Related issue (if applicable):** - upstream fix: https://github.com/Linkplay2020/wiim/pull/18 ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) — `bugfix` - [ ] New feature (non-breaking change which adds functionality) — `new-feature` - [ ] Enhancement to an existing feature — `enhancement` - [ ] New music/player/metadata/plugin provider — `new-provider` - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) — `breaking-change` - [ ] Refactor (no behaviour change) — `refactor` - [ ] Documentation only — `documentation` - [x] Maintenance / chore — `maintenance` - [ ] CI / workflow change — `ci` - [ ] Dependencies bump — `dependencies` Changes: - `volume_set()` calls `device.async_set_volume()` again instead of the inlined HTTP command - dropped the workaround comments and the private SDK call that came with them - re-enabled the volume error-handling test that was skipped for this workaround - pointed the invalid-data volume test at the public SDK method so it keeps testing something - added a test that the volume command actually reaches the device - added a test that the volume command actually reaches the device ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate.