/
/
# What does this implement/fix? A sync group outlives the session it was formed for, so a group you stopped yesterday still has its members. Two grouping actions never released those members, which left a speaker silent while it still showed up as grouped: - adding a Sendspin speaker to a stopped group left the group's other speakers behind, so only the one you added and the leader played - adding a speaker that already leads its own group to another group left it leading a group it can no longer serve from inside the new one Both come out of the same missing step: the old group is never given up. Found while reviewing #6051, which fixed a different route to the same silence. **Related issue (if applicable):** - found during review of #6051 ## Types of changes - [x] Bugfix (non-breaking change which fixes an issue) — `bugfix` - [ ] New feature (non-breaking change which adds functionality) — `new-feature` - [ ] Enhancement to an existing feature — `enhancement` - [ ] New music/player/metadata/plugin provider — `new-provider` - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) — `breaking-change` - [ ] Refactor (no behaviour change) — `refactor` - [ ] Documentation only — `documentation` - [ ] Maintenance / chore — `maintenance` - [ ] CI / workflow change — `ci` - [ ] Dependencies bump — `dependencies` Changes: - a stopped group's members move along with it when the group switches to another output, the same way a playing group's members already did - a speaker that leads its own group gives that group up before it joins another one - a speaker stays out of the new group instead of joining it twice when its own group is still playing, or when that group cannot be given up ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate.