/
/
/
# What does this implement/fix? The helper that names the speaker in a Sonos S1 error message carried two paths that can never run: a lookup for a `zone_name` attribute that no player has, and a fallback speaker argument that no caller passes. The dead path also carried a comment claiming it handled the player object, which is misleading to read. Every error already resolves the speaker the same way, so this keeps that one path and drops the rest. Errors name the same speaker as before. - Drop the unreachable `zone_name` branch and its stale comment. - Drop the `fallback_soco` argument that was threaded through the decorator but never used. - Move the now type-only `SoCo` import into the `TYPE_CHECKING` block. - Add test coverage for a speaker with no cached name, which is reported by its IP address. **Related issue (if applicable):** - n/a ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) — `bugfix` - [ ] New feature (non-breaking change which adds functionality) — `new-feature` - [ ] Enhancement to an existing feature — `enhancement` - [ ] New music/player/metadata/plugin provider — `new-provider` - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) — `breaking-change` - [ ] Refactor (no behaviour change) — `refactor` - [ ] Documentation only — `documentation` - [x] Maintenance / chore — `maintenance` - [ ] CI / workflow change — `ci` - [ ] Dependencies bump — `dependencies` ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate.