/
/
/
# What does this implement/fix? Some player settings only take effect when a new stream starts — things like the output codec, output channels, flow mode, sample rates, the HTTP profile, ICY metadata and the AirPlay sync adjust. Changing one of those while music was playing was supposed to briefly stop and resume playback so the new setting applied straight away, but that never happened: the check compared the plain setting name against the changed keys, which are stored with a `values/` prefix. As a result the setting was saved but you had to stop and start playback yourself before it did anything. - Compare the changed setting against the correct `values/<key>` form, matching how queue settings already do it - Added tests covering the restart, the no-restart case and an idle queue ## Types of changes - [x] Bugfix (non-breaking change which fixes an issue) — `bugfix` - [ ] New feature (non-breaking change which adds functionality) — `new-feature` - [ ] Enhancement to an existing feature — `enhancement` - [ ] New music/player/metadata/plugin provider — `new-provider` - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) — `breaking-change` - [ ] Refactor (no behaviour change) — `refactor` - [ ] Documentation only — `documentation` - [ ] Maintenance / chore — `maintenance` - [ ] CI / workflow change — `ci` - [ ] Dependencies bump — `dependencies` ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate.