/
/
/
# What does this implement/fix? Follow-up to #5452, which left alone the fixtures that "merely share a name but differ in body". The Tidal tests were the worst case: ten test files each defined their own `provider_mock`, all variations on the same thing, and some missing bits the others had. That became a trap once #5452 hoisted `media_manager` into the directory's `conftest.py`, because that fixture depends on `provider_mock` and the conftest doesn't define one. It resolves from whichever module asks for it, so adding a `media_manager` test to `test_playlist.py` would silently get a mock with no `get_item_mapping` and fail on an unreadable `<Mock name='mock.get_item_mapping().item_id'>` comparison instead of a clear error. The ten copies now merge into one shared `provider_mock` in the directory's `conftest.py`, so `media_manager` is self-contained and every module starts from the same fully-wired provider. - one `provider_mock` in `tests/providers/tidal/conftest.py`, merged from the ten module copies - `test_streaming.py` keeps a small same-name override for the parts only it needs (streaming quality and the throttler bypass) - the note on `media_manager` explaining the cross-module resolution is no longer needed **Related issue (if applicable):** - n/a ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) — `bugfix` - [ ] New feature (non-breaking change which adds functionality) — `new-feature` - [ ] Enhancement to an existing feature — `enhancement` - [ ] New music/player/metadata/plugin provider — `new-provider` - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) — `breaking-change` - [ ] Refactor (no behaviour change) — `refactor` - [ ] Documentation only — `documentation` - [x] Maintenance / chore — `maintenance` - [ ] CI / workflow change — `ci` - [ ] Dependencies bump — `dependencies` ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate.