/
/
/
# What does this implement/fix? A player is added to the player registry *before* its configuration is loaded, so anything that unregisters it in the meantime — a provider reload, or a speaker dropping off the network mid-setup — could interleave with its own setup. When that happened the setup carried on regardless: it announced a player that had already been removed and left a queue behind for it that nothing would ever clean up. Related to the review of #5483, which surfaced this. - Registration now stops as soon as its player is dropped or replaced. - A queue restored after the player was already removed is cleaned up again. - A player is never swapped out while its setup is still running. - When a player is replaced by a fresh instance, it now hands over its configuration and is marked as ready. Previously the replacement was left with empty settings and disappeared from the interface entirely — a sync group would come back without its members, for example. - Moved the MAC address lookup into its own helper to keep the registration routine readable. ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) — `bugfix` - [ ] New feature (non-breaking change which adds functionality) — `new-feature` - [ ] Enhancement to an existing feature — `enhancement` - [ ] New music/player/metadata/plugin provider — `new-provider` - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) — `breaking-change` - [ ] Refactor (no behaviour change) — `refactor` - [ ] Documentation only — `documentation` - [x] Maintenance / chore — `maintenance` - [ ] CI / workflow change — `ci` - [ ] Dependencies bump — `dependencies` ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate.