/
/
# What does this implement/fix? When connecting to an MPD server failed halfway through, Music Assistant left the connection it had already opened behind. The most common case is a password-protected MPD server: the connection is accepted, the password is then rejected, and the player is marked as needing setup — but the open connection stays there. Every retry adds another one, and MPD servers only allow a limited number of connections. Unloading an MPD player also left a pending reconnect attempt armed, so a player that was removed while its server was unreachable could come back a few seconds later and open connections nobody would ever close. **Related issue (if applicable):** - n/a ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) — `bugfix` - [ ] New feature (non-breaking change which adds functionality) — `new-feature` - [ ] Enhancement to an existing feature — `enhancement` - [ ] New music/player/metadata/plugin provider — `new-provider` - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) — `breaking-change` - [ ] Refactor (no behaviour change) — `refactor` - [ ] Documentation only — `documentation` - [x] Maintenance / chore — `maintenance` - [ ] CI / workflow change — `ci` - [ ] Dependencies bump — `dependencies` Changes: - Close both MPD connections whenever connecting fails partway through. - Always start a (re)connect from a clean slate, so a reconnect can never overwrite a still-open connection. - Cancel any pending reconnect when a player is disconnected or unloaded, including a connect attempt that is still in progress. - Added tests covering the failed-password and failed-idle-connection paths. ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate.