/
/
/
# What does this implement/fix? PR #5453 added a `join_task()` helper for waiting on work that is shared between callers. Seven older call sites still had their own copy of exactly the same code, each with the same five-line explanation attached, so the codebase had two ways of doing one thing. These now all use the helper. No behaviour change — the helper does exactly what the inlined code did, and the existing tests pass untouched. - Converted the remaining hand-rolled waits in `helpers/util.py`, `helpers/colors.py`, `helpers/images.py` and `models/recommendation_payload.py` to `join_task()` - Dropped the duplicated explanation comments (that reasoning now lives in the helper itself), keeping the one site-specific note ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) — `bugfix` - [ ] New feature (non-breaking change which adds functionality) — `new-feature` - [ ] Enhancement to an existing feature — `enhancement` - [ ] New music/player/metadata/plugin provider — `new-provider` - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) — `breaking-change` - [ ] Refactor (no behaviour change) — `refactor` - [ ] Documentation only — `documentation` - [x] Maintenance / chore — `maintenance` - [ ] CI / workflow change — `ci` - [ ] Dependencies bump — `dependencies` ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate.