/
/
/
# What does this implement/fix? When a player provider is unloaded (reloaded, disabled or removed), Music Assistant unregisters all of its players. That cleanup used the provider's own player listing, which hides disabled players — so a disabled player was silently skipped: its cleanup hook never ran (leaving connections and subscriptions open) and a dead entry stayed behind in the player registry, pointing at a provider that no longer exists. A player that was still in the middle of being set up was skipped for the same reason. Most providers unregister a player the moment it gets disabled, so this only surfaces with providers that deliberately keep disabled players around — MSX Bridge does, so its players stay visible in the list when re-enabled. Unloading now walks the player registry directly, so every player belonging to the provider is cleaned up properly. ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) — `bugfix` - [ ] New feature (non-breaking change which adds functionality) — `new-feature` - [ ] Enhancement to an existing feature — `enhancement` - [ ] New music/player/metadata/plugin provider — `new-provider` - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) — `breaking-change` - [ ] Refactor (no behaviour change) — `refactor` - [ ] Documentation only — `documentation` - [x] Maintenance / chore — `maintenance` - [ ] CI / workflow change — `ci` - [ ] Dependencies bump — `dependencies` ## Checklist - [x] The code change is tested and works locally. - [x] `pre-commit run --all-files` passes. - [x] `pytest` passes, and tests have been added/updated under `tests/` where applicable. - [ ] For changes to shared models, the companion PR in `music-assistant/models` is linked. - [ ] For changes affecting the UI, the companion PR in `music-assistant/frontend` is linked. - [x] I have read and complied with the project's [AI Policy](https://github.com/music-assistant/.github/blob/main/AI_POLICY.md) for any AI-assisted contributions. - [ ] I have [raised a PR against the documentation repository](https://github.com/music-assistant/music-assistant.io/blob/main/CONTRIBUTING.md) targeting the main or beta branch as appropriate.